Flink: Dynamic Sink: Use max write parallelism if none is supplied #14191
+46
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| static int firstPositive(int first, int second) { | ||
| if (first > 0) { | ||
| return first; | ||
| } |
| } | ||
| if (second > 0) { | ||
| return second; | ||
| } |
| if (second > 0) { | ||
| return second; | ||
| } | ||
| throw new IllegalArgumentException("None of the supplied ints were positive!"); |
There was a problem hiding this comment.
Should we print out both values to facilitate troubleshooting?
pvary
reviewed
Sep 28, 2025
| * @param rowData The data matching the provided schema. | ||
| * @param partitionSpec The target table {@link PartitionSpec}. | ||
| * @param distributionMode The {@link DistributionMode}. | ||
| * @param writeParallelism The number of parallel writers. If set to {@literal <= 0}, will |
There was a problem hiding this comment.
What if we set it to MAX_INT. It is easier to calculate with min later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the option to automatically set the write parallelism to the max available write parallelism, i.e. the job parallelism.