test(connectors): add integration tests for Quickwit sink #2609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
hey, thanks for contribution. if you want our CI to run your tests, you need to unmark it as a draft - CI won't run on drafts. EDIT: i'm wrong, please ignore this :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to #2594.
Added integration tests- things tested for mentioned in the "What needs testing" section of #2594.
flush_quickwit_test_indexmight be a bit flaky based on memory with initialcargo test. Have recently ran it like >5 times with no failures though. So want to see how it fairs in the CI pipeline. I guess hold off any review/merge for now."Bulk ingest behavior" not sure if I'm misinterpreting what this means w.r.t the test
given_bulk_message_send_should_store.