Fix/deferred location config

[alasdairhodge]

Resolves issues with $brooklyn:external() in location config:

• TypeCoercions resolves DeferredSupplier values
• locations constructed within a new execution context on LocalLocationManager so that relevant context objects can be retrieved in a consistent way

[alasdairhodge]

Once this is reviewed/merged into master, I'll issue the same fix against 0.8.x.

[aledsage]

Do we really need to create our own BasicExecutionManager? Can we not reuse managementContext.getExecutionManager()?

[aledsage]

@alasdairhodge Looks good. Only one important comment about reusing the ManagementContexts ExecutionManager, rather than creating a new one.

[aledsage]

Actually, can we have a test that externalised configuration now works in locations? As I recall, it was only in one situation that it failed - when the config was accessed during the init of the location object? For example in JcloudsLocation.setCreationString(), which is called by JcloudsLocation.configure()?

[aledsage]

How about a test like this in ExternalConfigYamlTest:

@Test
public void testExternalisedLocationConfigAccessedDuringLocationInit() throws Exception {
    String yaml = Joiner.on("\n").join(
        "services:",
        "- type: org.apache.brooklyn.core.test.entity.TestApplication",
        "location:",
        "  aws-ec2:",
        "    identity: myidentity",
        "    credential: mycredential",
        "    region: $brooklyn:external(\"myprovider\", \"mykey\")");

    TestApplication app = (TestApplication) createAndStartApplication(new StringReader(yaml));
    waitForApplicationTasks(app);
    LocationInternal loc = (LocationInternal) Iterables.getOnlyElement( app.getLocations() );
    assertEquals(loc.config().getLocalBag().getDescription(), "aws-ec2:myHardcodedVal");
}

Does that now pass for you? It fails for me in master:

org.apache.brooklyn.util.exceptions.CompoundRuntimeException: Unable to instantiate item, 2 errors including: Transformer for brooklyn-camp gave an error creating this plan: Illegal parameter for 'location' (aws-ec2); not resolvable: java.lang.ClassCastException: org.apache.brooklyn.camp.brooklyn.spi.dsl.methods.BrooklynDslCommon$DslExternal cannot be cast to java.lang.String

[aledsage]

@alasdairhodge any progress on including that test and getting it to pass? Ping me if you want to discuss or pair.

[ahgittin]

@alasdairhodge ping

[ahgittin]

@alasdairhodge ping