Improvements to brooklyn-server/rest/rest-api

[andreaturli]

• remove duplication of jackson and jackson2 on brooklyn project
• refactor pojos to have a consistent toString, hashCode and equals
• refactor pojos to use jackson2
• adapt code to the new jackson2 api where needed

@ahgittin I'd appreciate your thoughts particularly on BrooklynJacksonJsonProvider as jackson api are significantly changed in that area.

Notice this is not ready to be merged as even if brooklyn-server/rest sub-modules are building fine, but karaf section need to be fixed. I'd appreciate any help from karaf experts.

[ahgittin]

is this file now removed from source control? i know there was talk of this, but here it looks like it is being added back in.

[neykov]

It's been removed, but not ignored. Better ignore instead of adding it back.

[neykov]

Or even better - generate it somewhere under target/. Will look into this.

[CMoH]

I have removed the file and supposedly the pom instructions that generate it. If the file keeps reappearing we can gitignore it, and ungitignore+add it later on if we need it.

[ahgittin]

@andreaturli - this looks really good.

@neykov is working with @CMoH on porting the REST API to CXF. that should help w any karaf issues but might hurt with conflicts elsewhere. shouldn't be too bad though, these changes are relatively self-contained. check with them on whether they can merge this in to their work.

I think

[CMoH]

Feel free to merge before #1140. That PR already has merge conflicts, that will more time to resolve anyway. I think there's no point holding this back in the meantime.

[andreaturli]

thanks @CMoH
Anyway I see problems with jenkins with this PR as well. I'll try closing and reopening it to force a new build if it was just temporary.

[ahgittin]

strange test failure. can't tell if it is related to this or a new intermittent one.

[neykov]

@andreaturli Build failure in karaf-itest is due to feature.xml containing dependencies referencing ${jackson.version} property. The file is manually updated so you'll have to repeat the dependency changes in it as well.

@CMoH do you know of any maven config that will abort the build on discrepancy between feature.xml and the transitive maven dependencies?

[neykov]

And also delete dependencies.xml - not needed any more.

[CMoH]

@neykov There are two possible ways I know of here: one is using the karaf:verify goal of karaf-maven-plugin. However, I've tested this on another project and it seems to have some problems. Here are some details: https://karaf.apache.org/manual/latest/developers-guide/karaf-maven-plugin-features-validate-descriptor.html (note that the goal was renamed to karaf:verify in the latest versions, as can be seen here: https://github.com/apache/karaf/blob/master/tooling/karaf-maven-plugin/src/main/java/org/apache/karaf/tooling/VerifyMojo.java)

The other is using the itest project to test that each feature works fine. This takes a lot of time to execute, though, and as such I'd go for the first option.