This repository was archived by the owner on Nov 12, 2025. It is now read-only.
fix failing (time sensitive) test#1178
Merged
asfgit merged 1 commit intoapache:masterfrom Jan 30, 2016
Merged
Conversation
and improve the "Asserts.eventually" routines which that used, adding a new simpler eventuallyOnNotify(...) and having it used elsewhere. also add convenience methods for CountdownTimer so its usage is more readable.
Contributor
Author
Contributor
|
Looks good to me. One minor query on a comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solves the nondet test failure observed in #1176 .
and improve the "Asserts.eventually" routines which that used,
adding a new simpler eventuallyOnNotify(...) and having it used elsewhere.
also add convenience methods for CountdownTimer so its usage is more readable.