Wildfly 8 Support (Partial)

[mikezaccardo]

Wildfly 8 is now partially supported. brooklyn.entity.webapp.jboss.Wildfly8Server can now be used in place of brooklyn.entity.webapp.jboss.JBoss7Server in the example blueprints.

However, Wildfly 8's Undertow subsystem does not yet provide several required statistics that are used by certain policies -- for example, an auto-scaling policy configured to use the requests-per-second metric would not yet work.

The JBoss / Wildfly live tests have been refactored and Wildfly 8 live tests have been added (integration tests not yet added). Note that they will not yet pass due to the missing metrics.

See: https://issues.apache.org/jira/browse/BROOKLYN-142

[asfbot]

incubator-brooklyn-pull-requests #1092 FAILURE
Looks like there's a problem with this pull request

[asfbot]

incubator-brooklyn-pull-requests #1094 FAILURE
Looks like there's a problem with this pull request

[asfbot]

incubator-brooklyn-pull-requests #1095 SUCCESS
This pull request looks good

[asfbot]

incubator-brooklyn-pull-requests #1097 FAILURE
Looks like there's a problem with this pull request

[asfbot]

incubator-brooklyn-pull-requests #1099 SUCCESS
This pull request looks good

[aledsage]

Wildlfy, rather than AS7.

[aledsage]

As with the Wildfly AWS test, will this fail because the attributes aren't being set? In which case we should include a comment explaining why.

Could also parameterise the super.doTest() to say whether to assert those attributes are non-null.

[mikezaccardo]

Moved all to WIP with explanation.

[aledsage]

Thanks @mikezaccardo - looking good. A few minor comments, some of which should be addressed and many of which should be deferred.

You said in the description that the live tests "will not yet pass due to the missing metrics". Given we'll not get those metrics out of Wildfly in the short term, is there something we should do to get the live tests passing? For example, parameterise the doTest() method to say whether to assert the attributes have been set?

Would be good to have some tests that pass, so we can regression test this after it's been merged.

[mikezaccardo]

As per discussion with @aledsage, this is not going to be merged just yet. I will work adding tests that will pass given the incomplete state of Wildfly's metrics, and cleanup whatever else is deemed necessary.

[asfbot]

incubator-brooklyn-pull-requests #1363 FAILURE
Looks like there's a problem with this pull request

[asfbot]

incubator-brooklyn-pull-requests #1377 SUCCESS
This pull request looks good