Replace synchronized with ReentrantLock in saga module#8008
Open
somiljain2006 wants to merge 5 commits intoapache:2.xfrom
Open
Replace synchronized with ReentrantLock in saga module#8008somiljain2006 wants to merge 5 commits intoapache:2.xfrom
somiljain2006 wants to merge 5 commits intoapache:2.xfrom
Conversation
Author
|
@slievrly @funky-eyes Can you please review this? |
funky-eyes
reviewed
Mar 5, 2026
...main/java/org/apache/seata/saga/engine/pcext/interceptors/ServiceTaskHandlerInterceptor.java
Outdated
Show resolved
Hide resolved
Author
|
@funky-eyes I have done the required changes. Can you review them? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Replace usages of synchronized with ReentrantLock in saga related modules to avoid virtual thread pinning when using JDK 21 virtual threads.
Ⅱ. Does this pull request fix one issue?
Fixes #7173
Ⅲ. Why don't you add test cases (unit test/integration test)?
This PR only replaces
synchronizedwithReentrantLockfor Loom compatibility and does not change business logic. Existing unit tests already cover the affected code paths and pass successfully.Ⅳ. Describe how to verify it
Run this command - grep -R "synchronized (" saga --include="*.java" | grep src
Expected result: no output.
Ⅴ. Special notes for reviews
N/A