Skip to content

Conversation

brandboat
Copy link
Member

Add back rewrite rule to Dockerfile to fix broken top nav link in docker preview.

@brandboat
Copy link
Member Author

before:

2025-09-02.10.53.31.mov

after:

2025-09-02.10.54.38.mov

@brandboat
Copy link
Member Author

gentle ping @chia7712, @m1a2st, could you please take a look? The rewrite rule was removed in #665 and make top nav link broken. Thank you!

Copy link
Contributor

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I tested this branch, the zk2kraft.html page failed due to this policy.

CleanShot 2025-09-02 at 23 08 48

@brandboat
Copy link
Member Author

When I tested this branch, the zk2kraft.html page failed due to this policy.

@m1a2st, It looks like you followed the instructions in How to preview the latest documentation changes in Kafka repository?
, right? To work around the 404 error, try renaming the dev directory to 42 — that should help.

I think this is a separate issue. I’ve already checked out the asf-site branch, and the same problem still occurs.

That said, it might be worth updating the README.md. For example, the link shown in your video points to /{{version}}/documentation.html#upgrade_4_0_1, which should actually be /42/documentation.html#upgrade_4_0_1. The {{version}} comes from dev/js/templateData.js. Since the {{version}} placeholder isn’t being replaced properly, it results in a 404 error because the path doesn’t exist.

Copy link
Contributor

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That said, it might be worth updating the README.md. For example, the link shown in your video points to /{{version}}/documentation.html#upgrade_4_0_1, which should actually be /42/documentation.html#upgrade_4_0_1. The {{version}} comes from dev/js/templateData.js. Since the {{version}} placeholder isn’t being replaced properly, it results in a 404 error because the path doesn’t exist.

Yes, I completely agree that we should update the README file. We can handle this in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants