Fix ISO Latin-1 decoder sign extension#660
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix sign-extension corruption in
ISOLatinCharsetDecoder::decodewhen decoding bytes >=0x80.charsetdecoder.cpppreviously converted input bytes using:Because
charis signed by default on common MSVC/GCC/Clang x86/x64 builds, bytes in the range0x80..0xFFwere sign-extended to0xFFFFFFxx. This causedTranscoder::encodeto treat them as invalid Unicode values, producingU+FFFDon UTF-8 builds (or invalidwchar_tvalues on WCHAR builds).The fix casts through
unsigned charfirst, matching the existing unsigned-byte handling patterns already used elsewhere in the codebase.Impact
properties.cppselects this decoder for Java.propertiesparsing, so any Latin-1 characters above ASCII in log4cxx configuration files could be silently corrupted. This affects cases such as:Changes
ISOLatinCharsetDecoder::decodetestISOLatinHighBytes0x80..0xFF