Cleanup DOMUtils #15053
Open
Cleanup DOMUtils #15053
+15
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sandesh Kumar <[email protected]>
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
Signed-off-by: Sandesh Kumar <[email protected]>
jainankitk
reviewed
Aug 13, 2025
Comment on lines
-184
to
-196
| public static Document loadXML(Reader is) { | ||
| DocumentBuilderFactory dbf = DocumentBuilderFactory.newInstance(); | ||
| DocumentBuilder db = null; | ||
|
|
||
| try { | ||
| db = dbf.newDocumentBuilder(); | ||
| } catch (Exception se) { | ||
| throw new RuntimeException("Parser configuration error", se); | ||
| } | ||
|
|
||
| // Step 3: parse the input file | ||
| org.w3c.dom.Document doc = null; | ||
| try { |
There was a problem hiding this comment.
I am assuming this method is unused, right? Even then, we cannot remove public method from public class without deprecating, as it might break clients
Comment on lines
-103
to
-116
| public static String getChildTextByTagName(Element e, String tagName) { | ||
| Element child = getChildByTagName(e, tagName); | ||
| return child != null ? getText(child) : null; | ||
| } | ||
|
|
||
| /* Convenience method to append a new child with text*/ | ||
| public static Element insertChild(Element parent, String tagName, String text) { | ||
| Element child = parent.getOwnerDocument().createElement(tagName); | ||
| parent.appendChild(child); | ||
| if (text != null) { | ||
| child.appendChild(child.getOwnerDocument().createTextNode(text)); | ||
| } | ||
| return child; | ||
| } |
There was a problem hiding this comment.
Same goes for these public methods
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Code cleanup of
DOMUtilsclassBoolean#valueOfchanged toBoolean#parseBooleandeflt->defaultValue