LUCENE-14611: Fix TestTermInSetQuery.testDuel OOM by reducing large r… #15118
+14
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andomized term sets
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
dweiss
requested changes
Aug 25, 2025
Comment on lines
+118
to
+122
| // final int numTerms = TestUtil.nextInt(random(), 1, 1 << TestUtil.nextInt(random(), 1, 10)); | ||
| final int numTerms = Math.min( | ||
| TestUtil.nextInt(random(), 1, 1 << TestUtil.nextInt(random(), 1, 10)), | ||
| maxTerms | ||
| ); |
There was a problem hiding this comment.
I'd reuse RandomizedTest.randomIntBetween(...) instead of this code.
dweiss
reviewed
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue where TestTermInSetQuery.testDuel occasionally ran into OutOfMemoryError during randomized stress tests.
🔧 Changes Made:
Updated testDuel to limit the size of randomly generated terms and queries.
Added safeguards to avoid unbounded memory usage during stress test execution.
Ensured the test remains effective in validating correctness while being memory-efficient.
✅ Verification:
Ran affected test multiple times locally to confirm no OutOfMemoryError occurs.
Verified test correctness and consistency across different seeds.