add file name fall back in check algorithm #8654
Open
+17
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all jar files appear to have a pom.properties file with maven coordinates. Making up maven coordinates for such cases is unsafe (just guessing), so accept the jar file name if no maven coordinates exist
matthiasblaesing
requested changes
Aug 31, 2025
There was a problem hiding this comment.
What is the intention here? I don't get the problem that is being solved with this PR.
The task CheckEmbeddedBinaries is only ever invoked by the build of java/maven.embedded. It is part of the infrastructure that allows to resolve maven coordinates from SHA1 values of the corresponding JARs. It seems this option is currently being unused.
The task to check if the list contains the right binaries is IMHO correctly implemented. java/maven.embedder/external/binariesembedded-list is slit into pairs of SHA1 sum and maven coordinate. Then each jar inside apache-maven-<version>.zip is checked if it is in the list and matches the checksum.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all jar files appear to have a pom.properties file with Maven coordinates. Making up maven coordinates for such cases is unsafe (just guessing), so accept the jar file name if no maven coordinates exist
This modified CheckEmbeddedBinaries adds an optional column the 'manifest file'
with the value of the jar file for which the checksum is to be computed.
Other changes have to do with keeping order of manifest file and order of processing the same.
^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)