Skip to content

Conversation

haidubogdan
Copy link
Contributor

@haidubogdan haidubogdan commented Aug 24, 2025

This is a pull request to fix Twig 3.15 inline comments. (#8100)

Before :

image

After:

image

It is not a perfect solution as the following snippet will be seen as normal.

{{ "Hello World"|upper # this is an inline comment }}
image

This snippet will trigger a parser error on a real usage.
Unfortunately, the fix for this is more complex and can take more time as it is done on twig top lexer.
I need to check if the "#" symbol is in string or not, if it will finish with a new line or not, for which I sense that jflex lexer has some limitations and the current logic is hard to adapt.


^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

@troizet troizet added the PHP [ci] enable extra PHP tests (php/php.editor) label Aug 24, 2025
@mbien mbien linked an issue Aug 25, 2025 that may be closed by this pull request
@troizet troizet requested review from tmysik and junichi11 August 25, 2025 02:45
Copy link
Member

@tmysik tmysik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Twig 3.15 inline comments
3 participants