Skip to content

UnusedDetector: add missing RECORD label #8930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2025
+51 −1
Merged

UnusedDetector: add missing RECORD label #8930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion java/java.editor.base/src/org/netbeans/modules/java/editor/base/semantic/UnusedDetector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ public boolean isDependencies() {
typeElement = info.getElementUtilities().enclosingTypeElement(el);
searchKinds = EnumSet.of(ClassIndex.SearchKind.METHOD_REFERENCES);
}
case ANNOTATION_TYPE, CLASS, ENUM, INTERFACE -> {
case ANNOTATION_TYPE, CLASS, ENUM, RECORD, INTERFACE -> {
List<? extends TypeElement> topLevelElements = info.getTopLevelElements();
if (topLevelElements.size() == 1 && topLevelElements.get(0) == el) {
return false;
Expand Down
50 changes: 50 additions & 0 deletions java/java.hints/test/unit/src/org/netbeans/modules/java/hints/bugs/UnusedTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,4 +85,54 @@ public void testUnusedNoPackagePrivate() throws Exception {
.run(Unused.class)
.assertWarnings();
}

public void testNoFixForTopLevelPackagePrivateClass() throws Exception {
HintTest.create()
.input(
"""
package test;
class Test {
}
""")
.run(Unused.class)
.assertWarnings();
}

public void testNoFixForTopLevelPackagePrivateEnum() throws Exception {
HintTest.create()
.input(
"""
package test;
enum Test {
}
""")
.run(Unused.class)
.assertWarnings();
}

public void testNoFixForTopLevelPackagePrivateInterface() throws Exception {
HintTest.create()
.input(
"""
package test;
interface Test {
}
""")
.run(Unused.class)
.assertWarnings();
}

public void testNoFixForTopLevelPackagePrivateRecord() throws Exception {
HintTest.create()
.sourceLevel(17)
.input(
"""
package test;
record Test() {
}
""")
.run(Unused.class)
.assertWarnings();
}

}
Loading