[NIFI-13318] processor stop and configure UX #9548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
reviewing... |
rfellows
requested changes
Nov 22, 2024
Contributor
rfellows
left a comment
rfellows
left a comment
There was a problem hiding this comment.
A few things I noticed while using it...
After transitioning from running -> stopped or stopped -> running, the dialog isn't fully in edit/readonly mode respectively.
- Meaning, if I start a processor that was stopped when I opened the dialog, the button makes the appropriate transition to "Close" and the form won't submit. But the the property editors appear editable and the inputs on the relationships tab remain enabled.
- Inversely, stopping processor that was running when opening the dialog, the dialog becomes "Apply"able but the property editors remain in a read-only state as well as the inputs on the relationships tab.
...p/pages/flow-designer/ui/canvas/items/processor/edit-processor/edit-processor.component.html
Outdated
Show resolved
Hide resolved
...p/pages/flow-designer/ui/canvas/items/processor/edit-processor/edit-processor.component.html
Outdated
Show resolved
Hide resolved
...app/pages/flow-designer/ui/canvas/items/processor/edit-processor/edit-processor.component.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
I have also added the processor bulletins: 
|
Contributor
Author
@rfellows please check these again as they should be working now. |
scottyaslan
force-pushed
the
NIFI-13318
branch
2 times, most recently
from
043e835 to
42ea7f0
Compare
mcgilman
reviewed
Dec 6, 2024
Contributor
mcgilman
left a comment
mcgilman
left a comment
There was a problem hiding this comment.
Thanks for the PR @scottyaslan! I've noted a few things below.
...p/pages/flow-designer/ui/canvas/items/processor/edit-processor/edit-processor.component.html
Outdated
Show resolved
Hide resolved
...p/pages/flow-designer/ui/canvas/items/processor/edit-processor/edit-processor.component.html
Outdated
Show resolved
Hide resolved
...p/pages/flow-designer/ui/canvas/items/processor/edit-processor/edit-processor.component.html
Outdated
Show resolved
Hide resolved
...app/pages/flow-designer/ui/canvas/items/processor/edit-processor/edit-processor.component.ts
Outdated
Show resolved
Hide resolved
...-frontend/src/main/frontend/apps/nifi/src/app/pages/flow-designer/state/flow/flow.effects.ts
Show resolved
Hide resolved
...app/pages/flow-designer/ui/canvas/items/processor/edit-processor/edit-processor.component.ts
Outdated
Show resolved
Hide resolved
...app/pages/flow-designer/ui/canvas/items/processor/edit-processor/edit-processor.component.ts
Outdated
Show resolved
Hide resolved
...app/pages/flow-designer/ui/canvas/items/processor/edit-processor/edit-processor.component.ts
Outdated
Show resolved
Hide resolved
...app/pages/flow-designer/ui/canvas/items/processor/edit-processor/edit-processor.component.ts
Outdated
Show resolved
Hide resolved
…n, update edit processor entity and readonly updates
…vision on run status changes
scottyaslan
force-pushed
the
NIFI-13318
branch
from
42ea7f0 to
af74c83
Compare
scottyaslan
force-pushed
the
NIFI-13318
branch
from
ce48b6f to
c295b47
Compare
scottyaslan
force-pushed
the
NIFI-13318
branch
from
f0e71e1 to
6c9b5fd
Compare
mcgilman
reviewed
Dec 9, 2024
Contributor
mcgilman
left a comment
mcgilman
left a comment
There was a problem hiding this comment.
Thanks for the updates @scottyaslan! I've noted a few more things below.
...p/pages/flow-designer/ui/canvas/items/processor/edit-processor/edit-processor.component.html
Outdated
Show resolved
Hide resolved
...app/pages/flow-designer/ui/canvas/items/processor/edit-processor/edit-processor.component.ts
Outdated
Show resolved
Hide resolved
...app/pages/flow-designer/ui/canvas/items/processor/edit-processor/edit-processor.component.ts
Outdated
Show resolved
Hide resolved
...app/pages/flow-designer/ui/canvas/items/processor/edit-processor/edit-processor.component.ts
Outdated
Show resolved
Hide resolved
mcgilman
approved these changes
Dec 10, 2024
Contributor
mcgilman
left a comment
mcgilman
left a comment
There was a problem hiding this comment.
Thanks again for the updates @scottyaslan! Looks great, will merge once CI completes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And for processors with invalid run status: