Skip to content

Conversation

@pvillard31
Copy link
Contributor

Summary

NIFI-14072 - restore support for partial updates of labels

This PR restores the support for partial updates at labels level. It was removed in #9526. The logic is restored but moved in the DAO code that is not used when it comes to changing flow versions. This way proper behavior is restored and the fix from #9526 is maintained to not break flow versioning when style is changing.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for correcting this @pvillard31, I noted one minor syntax detail, otherwise looks good.

…/main/java/org/apache/nifi/web/dao/impl/StandardLabelDAO.java

Co-authored-by: David Handermann <exceptionfactory@apache.org>
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pvillard31, looks good! +1 merging

@exceptionfactory exceptionfactory merged commit 8d2db60 into apache:main Dec 14, 2024
7 checks passed
iadamcsik pushed a commit to iadamcsik/nifi that referenced this pull request Oct 22, 2025
Signed-off-by: David Handermann <exceptionfactory@apache.org>
(cherry picked from commit 8d2db60)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants