Skip to content

NIFI-14155 Improve ObjectMapper handling in TokenParserFactory#9648

Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-14155
Closed

NIFI-14155 Improve ObjectMapper handling in TokenParserFactory#9648
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-14155

Conversation

@exceptionfactory
Copy link
Contributor

Summary

NIFI-14155 Improves handling of the Jackson ObjectMapper in the TokenParserFactory interface and associated implementations. Improvements include refactoring the interface definition to remove configuration variables so that ObjectMapper and JsonFactory instances can be reused.

The refactored approach applies to JSON and YAML Record Readers as well as the Record Transform Proxy for Python Record Processors. The revised implementation creates instances of ObjectMapper with configured Stream Read Constraints on Controller Service enabling. With thread safety provided in JsonFactory and ObjectMapper, reusing these objects improves performance for repeated processing operations.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

- Refactored TokenParserFactory interface to accept InputStream without configuration parameters
- Avoided unnecessary ObjectMapper creation in JsonParserFactory
Copy link
Contributor

@pvillard31 pvillard31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @exceptionfactory - thanks for this improvement, this is going to make a huge difference performance wise. I did notice some formatting issues with additional whitespaces in TestJsonPathRowRecordReader, can you double check?

@exceptionfactory
Copy link
Contributor Author

Hey @exceptionfactory - thanks for this improvement, this is going to make a huge difference performance wise. I did notice some formatting issues with additional whitespaces in TestJsonPathRowRecordReader, can you double check?

Thanks for the review @pvillard31!

For whitespace, are you referring to the adjustments in the try-catch line spacing? The parameters for the Reader constructor changed, and in the process of making those changes, I noticed some of the second lines were not aligned with the first line inside the block, so that's the reason for some of the adjustments. If there is something else I am missing, please let me know.

Copy link
Contributor

@pvillard31 pvillard31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need more coffee... I didn't notice that it was a multi-lines try statement... Thanks @exceptionfactory - confirmed normal behavior on multiple flows. Code changes LGTM. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants