fix: patch futures buffer concurrent #6442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
tisonkun
commented
Jul 26, 2025
core/src/types/read/reader.rs
Outdated
| let merged_bufs: Vec<_> = | ||
| stream::iter(merged_ranges.clone().into_iter().map(|v| self.read(v))) | ||
| .buffered(self.ctx.options().concurrent()) | ||
| stream::iter(merged_ranges.clone().into_iter().map(|v| (self.read(v), 1))) |
There was a problem hiding this comment.
The second value is size.
Signed-off-by: tison <[email protected]> Co-authored-by: Andy Lok <[email protected]> Signed-off-by: tison <[email protected]>
tisonkun
force-pushed
the
fixup-buffered-ordered
branch
from
820aadf to
8968675
Compare
Xuanwo
reviewed
Jul 26, 2025
|
@Xuanwo do you mean |
|
The usage example could be found at: opendal/core/src/raw/oio/write/multipart_write.rs Lines 229 to 237 in 8de30cc |
Signed-off-by: tison <[email protected]>
dosubot
bot
added
size:M
Signed-off-by: tison <[email protected]>
tisonkun
changed the title
Signed-off-by: tison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rust-lang/futures-rs#2962
I'm afraid that futures-rs won't release recently, so try to bring the patch here.
What do you think? @Xuanwo @andylokandy