Make S3 roleARN optional
#2329
Merged
Make S3 roleARN optional
#2329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CLI will also require changes |
dimas-b
approved these changes
Aug 12, 2025
| @@ -51,6 +51,8 @@ at locations that better optimize for object storage. | |||
|
|
|||
| - Polaris Management API clients must be prepared to deal with new attributes in `AwsStorageConfigInfo` objects. | |||
|
|
|||
| - S3 configuration property role-ARN is no longer mandatory. | |||
There was a problem hiding this comment.
nit: S3 storage configuration property [...]
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
adutra
approved these changes
Aug 12, 2025
Good point, let me do that in the follow-up #2339 . |
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the role-arn parameter required for a catalog is redundant in many and requires the generation of an extra role in cases when IRSI (for AWS) is being used. Other S3 implementations (Minio, Ceph, many of the appliances) also do not all require a role-ARN.
Fixes #2325