Make PolarisAuthorizer RequestScoped #2340
Merged
+21
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
all methods in `PolarisAuthorizer` currently have a `CallContext` parameter. in its only implementation only `CallContext.getRealmConfig` is getting used. so since `PolarisAuthorizer` cant be used outside a request, we can simply make it request-scoped and inject the request-scoped `RealmConfig` directly.
XN137
commented
Aug 13, 2025
| @Produces | ||
| @RequestScoped | ||
| public PolarisAuthorizer polarisAuthorizer(RealmConfig realmConfig) { | ||
| return new PolarisAuthorizerImpl(realmConfig); |
There was a problem hiding this comment.
note: if any custom implementations of PolarisAuthorizer are out there and still need the CallContext for whatever reason, they are free to still inject it here.
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
adutra
approved these changes
Aug 13, 2025
donPain
approved these changes
Aug 13, 2025
|
The PR got 4 approvals and no objections, merging. |
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all methods in
PolarisAuthorizercurrently have aCallContextparameter.in its only implementation only
CallContext.getRealmConfigis getting used.so since
PolarisAuthorizercant be used outside a request, we can simply make it request-scoped and inject the request-scopedRealmConfigdirectly.