Relax ARN validation logic #3071
Open
+3
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following up on apache#3005, which allowed a wide range of ARN values in the validation RegEx, remove an additional explicit check for `aws-cn` being present in the ARN as a sub-string. Update existing unit tests to process `aws-cn` ARNs as common `aws` ARNs. Note: the old validation code does not look correct because it used to check for `aws-cn` anywhere in the ARN string, not just in its "partition" component.
Contributor
Author
|
Related |
adnanhemani
reviewed
Nov 17, 2025
| break; | ||
| case "aws-cn": | ||
| roleARN = "arn:aws-cn:iam::012345678901:role/jdoe"; | ||
| region = "Beijing"; |
Contributor
There was a problem hiding this comment.
"Beijing" is not a valid AWS region name. I know this is not explicitly part of the PR - but relates heavily to the scope and should be changed before we open this.
Contributor
Author
There was a problem hiding this comment.
Why should it be changed precisely?
Contributor
Author
There was a problem hiding this comment.
This is a unit test, it does not talk to AWS
Member
There was a problem hiding this comment.
The test never asserted on the region name.
I think it's out of scope to let Polaris validate AWS specific region names.
snazy
approved these changes
Nov 20, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #3005, which allowed a wide range of ARN values in the validation RegEx, remove an additional explicit check for
aws-cnbeing present in the ARN as a sub-string.Update existing unit tests to process
aws-cnARNs as commonawsARNs.Note: the old validation code does not look correct because it used to check for
aws-cnanywhere in the ARN string, not just in its "partition" component.Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)