Fix: remove the dependency from VirtualServiceAnalysisListener if GenAIAnalyzerModule is disabled.#13838
Merged
wankai123 merged 4 commits intoapache:masterfrom Apr 21, 2026
Merged
Conversation
…GenAIAnalyzerModule` is disabled.
wu-sheng
previously approved these changes
Apr 21, 2026
There was a problem hiding this comment.
Pull request overview
This PR prevents VirtualServiceAnalysisListener from failing when GenAIAnalyzerModule is not enabled in the OAP module configuration by making the GenAI processor registration conditional.
Changes:
- Guard
IGenAIMeterAnalyzerServicelookup withmoduleManager.has(GenAIAnalyzerModule.NAME)and only registerVirtualGenAIProcessorwhen available. - Update
changes.mdto document the fix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| oap-server/analyzer/agent-analyzer/src/main/java/org/apache/skywalking/oap/server/analyzer/provider/trace/parser/listener/VirtualServiceAnalysisListener.java | Makes GenAI processor/service optional so the listener works when GenAI module isn’t loaded. |
| docs/en/changes/changes.md | Adds a changelog entry describing the behavior change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
peachisai
previously approved these changes
Apr 21, 2026
wu-sheng
previously approved these changes
Apr 21, 2026
wu-sheng
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGESlog.