Skip to content

Force errorprone to max v2.31.0 on branch_9x #3567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: branch_9x
Choose a base branch
from
Draft

Force errorprone to max v2.31.0 on branch_9x #3567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,12 @@
"prConcurrentLimit": 100,
"prHourlyLimit": 10,
"branchPrefix": "renovate-9x/",
"commitMessageSuffix": " (branch_9x)"
"commitMessageSuffix": " (branch_9x)",
"packageRules": [
{
"description": "Skip errorprone upgrades since newer versions require JDK17",
"matchPackagePrefixes": ["com.google.errorprone"],
"enabled": false
}
]
}
12 changes: 12 additions & 0 deletions gradle/validation/error-prone.gradle
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your comment next to the version number in versions.props is enough, without needing this. But it's fine.

Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,18 @@ if (skipReason) {
}
}

configurations.all {
resolutionStrategy {
eachDependency { details ->
if (details.requested.group == "com.google.errorprone" &&
(details.requested.name == "error_prone_core" || details.requested.name == "error_prone_annotations")) {
details.useVersion("2.31.0")
details.because("Lock Error Prone dependencies to 2.31.0 to prevent accidental upgrades")
}
}
}
}

allprojects { prj ->
plugins.withType(JavaPlugin) {
// LUCENE-9650: Errorprone on master/gradle does not work when running as plugin
Expand Down
1 change: 1 addition & 0 deletions versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ com.github.ben-manes.caffeine:caffeine=3.1.8
com.github.spotbugs:*=4.8.6
com.github.stephenc.jcip:jcip-annotations=1.0-1
com.google.cloud:google-cloud-bom=0.224.0
# Errorprone must stay on 2.31.0 on 9.x to play nice with JDK11
com.google.errorprone:*=2.31.0
com.google.guava:guava=32.1.3-jre
com.google.protobuf:*=3.25.8
Expand Down