Skip to content

Conversation

@archan0621
Copy link

@archan0621 archan0621 commented Dec 7, 2025

Fix 62814: Use readable names for cluster channel/map options in documentation AND sample configurations

This patch updates several clustering documentation files to clarify that
both channelSendOptions and mapSendOptions accept human-readable option
names in addition to the existing integer bitmask values.

Tomcat already supports readable names (e.g., "async", "sync,use_ack"),
but the current documentation focuses primarily on numeric flags and
does not explicitly mention that mapSendOptions also supports the same
syntax. This can lead to confusion when configuring BackupManager or
interpreting sample configurations.

Changes included:

  • cluster-howto.xml: Updated explanations of send options and added
    references to readable option names. Improved consistency with the
    configuration reference.
  • cluster-manager.xml: Expanded the mapSendOptions attribute description
    to document readable names and clarify default behavior.
  • cluster-valve.xml: Minor adjustments to align terminology with the
    updated clustering documentation.

No functional code changes are included in this patch. This is a
documentation update only.

Please let me know if further adjustments or additional examples are
desired. I am happy to iterate on the patch.

@archan0621 archan0621 changed the base branch from 9.0.x to main December 29, 2025 06:50
@archan0621 archan0621 changed the base branch from main to 9.0.x December 29, 2025 06:51
markt-asf added a commit that referenced this pull request Jan 7, 2026
Documents the human-readable versions of the options. Also notes which
ones are NO-OPs.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62814
Based on PR #929 by archan0621
@markt-asf
Copy link
Contributor

Thanks for the PR. I used it as the basis of a fix I applied manually as there were a couple of additional points that may not have been immediately obvious:

  • not all the options have been implemented
  • some of the sample configurations needed to be updated to use the human-readable values
  • some of the options depend on other options

@markt-asf markt-asf closed this Jan 7, 2026
markt-asf added a commit that referenced this pull request Jan 7, 2026
Documents the human-readable versions of the options. Also notes which
ones are NO-OPs.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62814
Based on PR #929 by archan0621
markt-asf added a commit that referenced this pull request Jan 7, 2026
Documents the human-readable versions of the options. Also notes which
ones are NO-OPs.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62814
Based on PR #929 by archan0621
markt-asf added a commit that referenced this pull request Jan 7, 2026
Documents the human-readable versions of the options. Also notes which
ones are NO-OPs.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62814
Based on PR #929 by archan0621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants