API for Next Hop Strategy rebind during a transaction #12512
+956
−126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traeak
changed the title
traeak
force-pushed
the
strategy_rebind
branch
2 times, most recently
from
4009100 to
1d2557d
Compare
traeak
force-pushed
the
strategy_rebind
branch
from
23edfb3 to
4805259
Compare
This adds 'c' friendly api calls to get and set strategies, to get the name of a given strategy and to get a strategy from the strategy factory by name. Also includes additions to header_rewrite, regex_remap and lua plugins.
traeak
force-pushed
the
strategy_rebind
branch
from
a5939e5 to
8c1b741
Compare
|
Did you email the mailing list with the new API additions ? |
|
I think more tests need to be added for corner cases. Also on request am working on setting up a stress test case to ensure that converting the strategy shared_ptr to plain pointers doesn't result in faults. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds to the ts api to allows the selected parent strategy to be changed during a transaction using a 'c' friendly API.
APIs added:
Set and get via strategy pointer.
Gets the name of the provided strategy
The below looks up a strategy by name by using the current transaction to get to the NextHopStrategyFactory.
Support added to:
Ideally there also should be a way to make the NextHopStrategyFactory pointer directly available to TSRemapNewInstance.