Skip to content

Conversation

bneradt
Copy link
Contributor

@bneradt bneradt commented Sep 18, 2025

This adds more cleanup logic to redirect handling logic, cleaning up the tunnel and PluginVCs on redirect. This addresses a timeout crash we received on dispatch to a defunct plugin upon following a redirect from the escalate plugin.

This adds more cleanup logic to redirect handling logic, cleaning up the
tunnel and PluginVCs on redirect. This addresses a timeout crash we
received on dispatch to a defunct plugin upon following a redirect from
the escalate plugin.
@bneradt bneradt added this to the 10.2.0 milestone Sep 18, 2025
@bneradt bneradt requested review from JosiahWI and Copilot September 18, 2025 22:00
@bneradt bneradt self-assigned this Sep 18, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive cleanup logic to the redirect handling path in the HttpSM to prevent timeout crashes when following redirects from plugins. The fix addresses a specific crash scenario where a defunct plugin would receive dispatch events after a redirect from the escalate plugin.

  • Adds tunnel cleanup to kill active tunnels before redirect processing
  • Implements transform and plugin agent cleanup when hooks are set
  • Ensures plugin tunnels are properly terminated and nullified

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@bneradt bneradt marked this pull request as draft September 22, 2025 22:10
@bryancall bryancall requested a review from vmamidi September 22, 2025 22:11
@bneradt
Copy link
Contributor Author

bneradt commented Sep 22, 2025

Making this a draft because I want to bake this in Yahoo prod for longer to make sure this patch is stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant