Merged
Conversation
…ll, impossible_assertion (#17) Completes the production audit rule set from issue #14. Adds: - vacuous_property: detects fc.property callbacks with return-true paths that bypass assertions, and fc.constant-only generators (zero variation) - no_production_call: detects tests that call no imported production function, only exercising builtins or language guarantees - impossible_assertion: detects .length >= 0 and similar tautological checks that are mathematically impossible to fail Updates total rule count from 15 to 18 across presets, docs, and patterns. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the production audit rule set from #14. Adds the 3 remaining rules:
vacuous_property(should-fail): Detectsfc.propertycallbacks withreturn truepaths that bypass assertions (2a), andfc.constant-only generators with zero input variation (2b)no_production_call(should-fail): Detects tests that call no imported production function — only builtins, operators, or language guarantees. IncludesparseImports()helper for import tracking.impossible_assertion(should-fail): Detects assertions that are mathematically impossible to fail, e.g.expect(x.length).toBeGreaterThanOrEqual(0)Updates total rule count from 15 to 18 across presets, SKILL.md, and pattern reference.
Test plan
parseImportshelperCloses #17
🤖 Generated with Claude Code