-
-
Notifications
You must be signed in to change notification settings - Fork 77
fix(config): pnpm workspace #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I've cloned the repo and ran pnpm install and I did not reproduce the error you mentioned. What is your version of pnpm? |
|
My guess is that you are on an older pnpm version. The current package manager version is [email protected] |
|
Yes, I use pnpm@9, so the error comes from that. |
|
Did you see a message (warning) about your pnpm version when running the pnpm install command? Another solution could be to enable the packagemanagerstrictversion option, it would prevent the error but it is much stricter. |
|
Got only the line I pasted as error. Not really helpful ^^' Restricting pnpm version too strictly could discourage people from contributing. Maybe specify a range version. Or at the very least document the requirement for contributing in the readme. |
|
Unfortunately we can't specify a version range.
I've create #161 for that but I think we can merge yours Thanks 😉 |
|
@Fabious Can you fix the lockfile please? |
|
It is in fact possible to specify a version range: https://github.com/openjs-foundation/package-metadata-interoperability-collab-space/blob/main/devengines-field-proposal.md#typical-example |
When trying to contribute, I can't pnpm install on a fresh clone:
ERROR packages field missing or empty