Skip to content

Fix empty strings for date filter #7291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: 4.1
Choose a base branch
from
Draft

Fix empty strings for date filter #7291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Doctrine/Common/Filter/DateFilterTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,14 @@
return null;
}

if ('' === $value) {
$this->getLogger()->notice('Invalid filter ignored', [
'exception' => new InvalidArgumentException(\sprintf('Invalid value for "[%s]", expected non-empty string', $operator)),
]);

Check warning on line 97 in src/Doctrine/Common/Filter/DateFilterTrait.php

View check run for this annotation

Codecov / codecov/patch

src/Doctrine/Common/Filter/DateFilterTrait.php#L95-L97 

Added lines #L95 - L97 were not covered by tests

return null;

Check warning on line 99 in src/Doctrine/Common/Filter/DateFilterTrait.php

View check run for this annotation

Codecov / codecov/patch

src/Doctrine/Common/Filter/DateFilterTrait.php#L99 

Added line #L99 was not covered by tests
}

return $value;
}
}
Loading