Refactor commands/: split SensorControl.c into subsystem-specific files#273
Merged
Refactor commands/: split SensorControl.c into subsystem-specific files#273
Conversation
SensorControl.c (1,895 lines) mixed CLI handlers for 7 unrelated subsystems. Split into cohesive per-subsystem files and moved misplaced command implementations out of CommandLineTask.c and SoftwareCommands.c. Pure code-organization refactor with no behavioral changes. New files: - FireflyCommands.c/h (ff_* commands, read/write_ff_register) - PowerCommands.c/h (psmon/power_ctl, snapshot, psmon_reg) - AlarmCommands.c/h (alarm_ctl) - ClockCommands.c/h (clkmon/clk_* commands, clearclk, loadclock) - FPGACommands.c/h (fpga_ctl, fpga_flash, fpga_reset) - ZynqCommands.c/h (zmon_ctl, from SoftwareCommands) SensorControl.c retains only adc_ctl and led_ctl. bl_ctl moved from CommandLineTask.c to SoftwareCommands.c. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The commands/ directory refactoring (item #3) is done. Renumber remaining High Priority items accordingly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pwittich
force-pushed
the
update/refactor
branch
from
e2a78b3 to
8d7d7e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor SensorControl file.
PowerCommands, AlarmCommands, ClockCommands, FPGACommands, and ZynqCommands
init_load_clock_ctl) into their appropriate subsystem files