Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CM MCU ↔ ZynqMon monitoring map and Firefly power/alarms handling, and adds a new hardware-peripheral/pin assignment reference document for the TM4C1290.
Changes:
- Fold Firefly power-alarm reporting into the existing
firefly_infoZynqMon block (YAML + firmware), removing the separate power-alarm block. - Tighten Rev2/3 Firefly 4V0/3V8 slot validation during power-up by checking both “25G needs 4V0” and “4V0 slot must not contain non‑25G” conditions.
- Add
mcu_peripherals.mddocumenting MCU peripheral and pin assignments.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sm_cm_config/data/PL_MEM_CM_rev3.yml | Expands firefly block size, adds POWER_ALARM postfixes, shifts subsequent start offsets, removes separate power-alarm block. |
| sm_cm_config/data/PL_MEM_CM_rev2.yml | Same as rev3: expands firefly block, shifts offsets, removes separate power-alarm block. |
| projects/cm_mcu/ZynqMonTask.c | Adds POWER_ALARM_0/1 reporting into zm_set_firefly_info; removes standalone zm_set_firefly_power_alarm. |
| projects/cm_mcu/Tasks.h | Removes prototype for deleted zm_set_firefly_power_alarm. |
| projects/cm_mcu/PowerSupplyTask.c | Updates Rev2/3 Firefly slot validation logic using both “25G mask” and “presence mask”; improves failure handling path. |
| projects/cm_mcu/FireflyUtils.h | Declares new getFF12ChPresentTxMask() helper for Rev2/3. |
| projects/cm_mcu/FireflyUtils.c | Implements getFF12ChPresentTxMask() based on present_bit_mask. |
| mcu_peripherals.md | New documentation describing UART/I2C/ADC/timer usage and detailed pin assignments across revisions. |
Comment on lines
+437
to
439
| log_error(LOG_PWRCTL, "FF 4V0 part check failed: part present without 4V0 switch" | ||
| " (f1: sel=%x parts=%x, f2: sel=%x parts=%x), power off\r\n", | ||
| f1_ff12xmit_4v0_sel, pair_mask_f1, f2_ff12xmit_4v0_sel, pair_mask_f2); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and corrections to the Firefly (FF) power control and monitoring logic, MCU peripheral documentation, and ZynqMon data reporting. The main changes include a more robust check for Firefly presence and power wiring, improved error handling, expanded ZynqMon sensor reporting, and updated documentation for hardware pin assignments.