Skip to content

New README info architecture and content #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

New README info architecture and content #665

wants to merge 4 commits into from

Conversation

bignimbus
Copy link
Contributor

@bignimbus bignimbus commented Jun 6, 2025 •
edited
Loading

TODO

Before marking as ready for review:

  • Update other READMEs
  • Verify links

@netlify Netlify
Copy link

netlify bot commented Jun 6, 2025 •
edited
Loading

✅ Deploy Preview for apollo-ios-docc canceled.

Name Link
🔨 Latest commit 9ac078c
🔍 Latest deploy log https://app.netlify.com/projects/apollo-ios-docc/deploys/6866aed3b8da1100082c23aa

calvincestari
calvincestari requested changes Jun 6, 2025
View reviewed changes
Copy link
Member

@calvincestari calvincestari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, looks good otherwise - thank you!

@apollo-librarian
Copy link

apollo-librarian bot commented Jul 3, 2025 •
edited
Loading

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 20efcdbf3e0ab11c34291792

@bignimbus bignimbus marked this pull request as ready for review July 3, 2025 16:25
calvincestari
calvincestari approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@calvincestari calvincestari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you.

At some time we should change the build status badge too. I think that might be more relevant to apollo-ios-dev though with the nightly build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvincestari calvincestari calvincestari approved these changes

@martinbonnin martinbonnin Awaiting requested review from martinbonnin

@BobaFetters BobaFetters Awaiting requested review from BobaFetters

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bignimbus @calvincestari