-
Notifications
You must be signed in to change notification settings - Fork 65
Add isOneOf to inspection query in ApolloSchemaDownloader #705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@glenngijsberts: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
👷 Deploy request for apollo-ios-docc pending review.Visit the deploys page to approve it
|
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 7 changed, 0 removed
Build ID: 08d1b63c67a14a0de34272a3 URL: https://www.apollographql.com/docs/deploy-preview/08d1b63c67a14a0de34272a3 |
Thanks for the PR @glenngijsberts - this seems correct but I'm not sure we can merge it yet since the @martinbonnin / @BoD - is this why |
Indeed, selecting To work around this, we implemented "2 step introspection":
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glenngijsberts - we can see from @BoD's reply that there needs to be more thought put into this change. We cannot break schema downloads for servers out there today so we'll need something like the 2-stage approach that Kotlin has in place.
@calvincestari @BoD makes sense 👍 I'm gonna have another look at this upcoming week, to see if it's possible to do something similar. How could I test this? I'm having a bit trouble understanding how everything works in the project, so any advice would be helpful! |
In #537 the
@oneOf
directive was introduced. However, I noticed that the directive was not included in my schema when I did an introspection, and so the additional types were not generated.I had a look at the source code, and noticed that the
isOneOf
was missing from the inspection query done inApolloSchemaDownloader
. I've added it, but I wasn't really able to test this, so I was hoping if somebody can point me in the right direction or help me out with this 🙏