Skip to content

Add a specific issue type for fragment cycles #6759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2025
Merged

Add a specific issue type for fragment cycles #6759

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
628b0c5
Add a specific type for fragment cycles
martinbonnin Oct 31, 2025
25fd571
update apiDump
martinbonnin Oct 31, 2025
503eec0
update test fixtures
martinbonnin Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions libraries/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo/ast/Issue.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,13 @@ class DifferentShape(override val message: String, override val sourceLocation:

class UnusedFragment(override val message: String, override val sourceLocation: SourceLocation?) : GraphQLValidationIssue

/**
* There is a fragment cycle.
*
* See https://spec.graphql.org/September2025/#sec-Fragment-Spreads-Must-Not-Form-Cycles
*/
class FragmentCycle(override val message: String, override val sourceLocation: SourceLocation?) : GraphQLValidationIssue

/**
* Two type definitions have the same name
*/
Expand Down
3 changes: 2 additions & 1 deletion .../src/commonMain/kotlin/com/apollographql/apollo/ast/internal/ExecutableValidationScope.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import com.apollographql.apollo.ast.Catch
import com.apollographql.apollo.ast.DeprecatedUsage
import com.apollographql.apollo.ast.DifferentShape
import com.apollographql.apollo.ast.ExecutableValidationResult
import com.apollographql.apollo.ast.FragmentCycle
import com.apollographql.apollo.ast.GQLArgument
import com.apollographql.apollo.ast.GQLBooleanValue
import com.apollographql.apollo.ast.GQLDirective
Expand Down Expand Up @@ -117,7 +118,7 @@ internal class ExecutableValidationScope(
val index = path.indexOf("__${name}")
val nextPath = path + "__${fragment.name}"
if (index != -1) {
registerIssue("Fragment '$name' spreads itself, creating a cycle at '${nextPath.subList(index, nextPath.size).joinToString(".")}'", it.sourceLocation)
issues.add(FragmentCycle("Fragment '$name' spreads itself, creating a cycle at '${nextPath.subList(index, nextPath.size).joinToString(".")}'", it.sourceLocation))
cyclicFragments.add(name)
return@forEach
}
Expand Down
Loading