Repository navigation
fix(federation): keep renamed interfaces in their directives' referencers - #10380
Open
inanna-apollo wants to merge 1 commit into
Open
inanna-apollo wants to merge 1 commit into
inanna-apollo wants to merge 1 commit into
Conversation
Contributor
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 1 changed, 0 removedBuild ID: 2f4975a4fb0b3f2fd343587c URL: https://www.apollographql.com/docs/deploy-preview/2f4975a4fb0b3f2fd343587c ✅ AI Style Review — No Changes DetectedNo MDX files were changed in this pull request. Review Log: View detailed log
|
This comment has been minimized.
This comment has been minimized.
inanna-apollo
force-pushed
the
inanna/fix-14-interface-rename-directive-targets
branch
from
October 5, 2026 18:04
4dbc1ce to
530eb76
Compare
inanna-apollo
marked this pull request as ready for review
October 5, 2026 18:04
…cers Renaming an interface type left the old interface name in `Referencers.directives[d].interface_types` for every directive applied to it. The schema stayed valid, but directive lookups through the index (as used for `@key`, `@tag`, `@inaccessible` and other directive processing) named a type that no longer existed. `Referencers::rename_interface_type` now remaps directive target positions for the interface itself, as it already did for its fields and arguments.
inanna-apollo
force-pushed
the
inanna/fix-14-interface-rename-directive-targets
branch
3 times, most recently
from
October 5, 2026 18:24
530eb76 to
d91790e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renaming an interface type left the old interface name in
Referencers.directives[d].interface_typesfor every directive applied to it. The schema stayed valid, but directive lookups through the index (as used for@key,@tag,@inaccessibleand other directive processing) named a type that no longer existed.Referencers::rename_interface_typenow remaps directive target positions for the interface itself, as it already did for its fields and arguments.Reachability
Internal API only: production code never renames interfaces today. The stale referencer carries into the validated subgraph used by composition. Merge note: the schema rename PRs in this series each add the same referencer-rebuild check helper at the end of the
position.rstest module, so whichever lands second needs a trivial rebase (keep the helper once).Testing
The regression test(s) in this PR fail on
devand pass with this change; neighboring test suites pass with no snapshot changes. Found during property-based testing ofapollo-federation.Checklist