Repository navigation
fix(federation): update input value types and references when renaming an input object - #10384
Open
inanna-apollo wants to merge 1 commit into
Open
inanna-apollo wants to merge 1 commit into
inanna-apollo wants to merge 1 commit into
Conversation
Contributor
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 1 changed, 0 removedBuild ID: ac62b47ad0e86476a8e6b64c URL: https://www.apollographql.com/docs/deploy-preview/ac62b47ad0e86476a8e6b64c ✅ AI Style Review — No Changes DetectedNo MDX files were changed in this pull request. Review Log: View detailed log
|
inanna-apollo
force-pushed
the
inanna/fix-13-input-field-rename-type
branch
from
October 5, 2026 18:04
89914e8 to
3800b4a
Compare
inanna-apollo
force-pushed
the
inanna/fix-new-input-object-rename
branch
from
October 5, 2026 18:04
f40536b to
437118e
Compare
inanna-apollo
marked this pull request as ready for review
October 5, 2026 18:04
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
…g an input object `InputObjectTypeDefinitionPosition::rename` only re-keyed the input object's reference record. Field arguments, input fields and directive arguments that take the input object kept the old, removed name, making the schema invalid. The reference index also kept the old name in the positions of the renamed input object's own fields. The rename now rewrites the types of every referencing input value, preserving list and non-null wrappers, and `Referencers::rename_input_object_type` remaps the positions of the input object's fields. Rewriting input fields relies on the preceding fix to `InputObjectFieldDefinitionPosition::rename_type`.
inanna-apollo
force-pushed
the
inanna/fix-13-input-field-rename-type
branch
from
October 5, 2026 18:23
3800b4a to
91a4ff6
Compare
inanna-apollo
force-pushed
the
inanna/fix-new-input-object-rename
branch
3 times, most recently
from
October 5, 2026 18:24
88c0ced to
68e3e69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InputObjectTypeDefinitionPosition::renameonly re-keyed the input object's reference record. Field arguments, input fields and directive arguments that take the input object kept the old, removed name, making the schema invalid. The reference index also kept the old name in the positions of the renamed input object's own fields.The rename now rewrites the types of every referencing input value, preserving list and non-null wrappers, and
Referencers::rename_input_object_typeremaps the positions of the input object's fields. Rewriting input fields relies on the preceding fix toInputObjectFieldDefinitionPosition::rename_type.Stacked on #10379, which it depends on; review only the top commit. Retarget to
devonce that lands.Reachability
Internal API only. Renaming an input object skipped every argument, input field and directive argument using the type, leaving an invalid schema. Merge note: the schema rename PRs in this series each add the same referencer-rebuild check helper at the end of the
position.rstest module, so whichever lands second needs a trivial rebase (keep the helper once).Testing
The regression test(s) in this PR fail on
devand pass with this change; neighboring test suites pass with no snapshot changes. Found during property-based testing ofapollo-federation.Checklist