Skip to content

fix: Small doc corrections #7913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DEVELOPMENT.md
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ Code coverage is run in CI nightly, but not done on every commit. To view cover
To run code coverage locally, you can `cargo install cargo-llvm-cov`, and run:

```shell
cargo llvm-cov nextest -- --summary
cargo llvm-cov nextest --summary-only
```

For full information on available options, including HTML reports and `lcov.info` file support, see [nextest documentation](https://nexte.st/book/coverage.html) and [cargo llvm-cov documentation](https://github.com/taiki-e/cargo-llvm-cov#get-coverage-of-cc-code-linked-to-rust-librarybinary).
Expand Down
4 changes: 2 additions & 2 deletions apollo-router/src/plugin/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -360,15 +360,15 @@ pub trait Plugin: Send + Sync + 'static {
///
/// This service runs at the very beginning and very end of the request lifecycle.
/// It's the entrypoint of every requests and also the last hook before sending the response.
/// Define supergraph_service if your customization needs to interact at the earliest or latest point possible.
/// Define `router_service` if your customization needs to interact at the earliest or latest point possible.
/// For example, this is a good opportunity to perform JWT verification before allowing a request to proceed further.
fn router_service(&self, service: router::BoxService) -> router::BoxService {
service
}

/// This service runs after the HTTP request payload has been deserialized into a GraphQL request,
/// and before the GraphQL response payload is serialized into a raw HTTP response.
/// Define supergraph_service if your customization needs to interact at the earliest or latest point possible, yet operates on GraphQL payloads.
/// Define `supergraph_service` if your customization needs to interact at the earliest or latest point possible, yet operates on GraphQL payloads.
fn supergraph_service(&self, service: supergraph::BoxService) -> supergraph::BoxService {
service
}
Expand Down