Skip to content

Conversation

@bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Nov 26, 2025

Remove prefix _preview from preview_response_cache plugin config to make it GA.

Only merge it once we're ready to release 2.10.0 to not update docs too early.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@bnjjj bnjjj requested review from a team as code owners November 26, 2025 10:34
@bnjjj bnjjj marked this pull request as draft November 26, 2025 10:34
@apollo-librarian
Copy link

apollo-librarian bot commented Nov 26, 2025

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 9 changed, 0 removed
* graphos/routing/(latest)/configuration/yaml.mdx
* graphos/routing/(latest)/performance/caching/response-caching/customization.mdx
* graphos/routing/(latest)/performance/caching/response-caching/faq.mdx
* graphos/routing/(latest)/performance/caching/response-caching/invalidation.mdx
* graphos/routing/(latest)/performance/caching/response-caching/observability.mdx
* graphos/routing/(latest)/performance/caching/response-caching/overview.mdx
* graphos/routing/(latest)/performance/caching/response-caching/quickstart.mdx
* graphos/routing/(latest)/upgrade/from-router-v1.mdx
* graphos/routing/(latest)/federation-version-support.mdx

Build ID: 40b388ab7297828f98dbd915
Build Logs: View logs

URL: https://www.apollographql.com/docs/deploy-preview/40b388ab7297828f98dbd915

@github-actions

This comment has been minimized.

Signed-off-by: Benjamin <[email protected]>
@bnjjj bnjjj requested review from abernix and carodewig November 26, 2025 12:12
@bnjjj bnjjj marked this pull request as ready for review December 8, 2025 10:03
bnjjj added 5 commits December 8, 2025 11:07
Signed-off-by: Benjamin <[email protected]>
Signed-off-by: Benjamin <[email protected]>
Signed-off-by: Benjamin <[email protected]>
Signed-off-by: Benjamin <[email protected]>
Copy link
Contributor

@aaronArinder aaronArinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely get another review by @carodewig, especially for the --quiet flag on mise, but this lgtm

bnjjj added 5 commits December 8, 2025 16:03
Signed-off-by: Benjamin <[email protected]>
Signed-off-by: Benjamin <[email protected]>
Signed-off-by: Benjamin <[email protected]>
Signed-off-by: Benjamin <[email protected]>
Signed-off-by: Benjamin <[email protected]>
@abernix abernix merged commit 123d013 into dev Dec 8, 2025
15 checks passed
@abernix abernix deleted the bnjjj/response_cache_ga branch December 8, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants