-
Notifications
You must be signed in to change notification settings - Fork 327
Put response cache in GA and remove preview_ prefix
#8678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Benjamin <[email protected]>
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 9 changed, 0 removedBuild ID: 40b388ab7297828f98dbd915 URL: https://www.apollographql.com/docs/deploy-preview/40b388ab7297828f98dbd915 |
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Benjamin <[email protected]>
Signed-off-by: Benjamin <[email protected]>
Signed-off-by: Benjamin <[email protected]>
Signed-off-by: Benjamin <[email protected]>
Signed-off-by: Benjamin <[email protected]>
Signed-off-by: Benjamin <[email protected]>
aaronArinder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
definitely get another review by @carodewig, especially for the --quiet flag on mise, but this lgtm
Signed-off-by: Benjamin <[email protected]>
Signed-off-by: Benjamin <[email protected]>
Signed-off-by: Benjamin <[email protected]>
Signed-off-by: Benjamin <[email protected]>
Signed-off-by: Benjamin <[email protected]>
Remove prefix
_previewfrompreview_response_cacheplugin config to make it GA.Only merge it once we're ready to release
2.10.0to not update docs too early.Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩