Skip to content

Improvement/test coverage #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 3, 2025
Merged

Improvement/test coverage #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c949705
2.7.5
fuatguzel Sep 26, 2025
780a7b1
Merge branch 'develop' of https://github.com/appcircleio/appcircle-cl…
fuatguzel Oct 2, 2025
6289e27
Merge branch 'develop' of https://github.com/appcircleio/appcircle-cl…
fuatguzel Oct 3, 2025
977c2b4
refactor: export previously private functions in command-runner and i…
fuatguzel Oct 3, 2025
3565628
refactor: export private functions in writer-commands for improved ac…
fuatguzel Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions src/core/command-runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ export function createCleanTerminalFormatter() {
/**
* Create a step summary formatter that shows only build steps and durations
*/
function createStepSummaryFormatter() {
export function createStepSummaryFormatter() {
const stepStates = new Map<string, {
status: StepStatus;
startTime: number;
Expand Down Expand Up @@ -1270,7 +1270,7 @@ export const handleUnknownLoginCommand = (command: ProgramCommand): void => {
}
};

const handleLoginCommand = async (command: ProgramCommand, params: any) => {
export const handleLoginCommand = async (command: ProgramCommand, params: any) => {
// Check if user is already logged in
if (checkIfUserAlreadyLoggedIn()) {
// Validate if the current token is still valid
Expand Down Expand Up @@ -1322,7 +1322,7 @@ export const displayLogoutSuccessMessage = (): void => {
console.log('Successfully logged out from Appcircle.');
};

const handleLogoutCommand = async (command: ProgramCommand, params: any) => {
export const handleLogoutCommand = async (command: ProgramCommand, params: any) => {
// Check if user is logged in first
if (!checkIfUserIsLoggedIn()) {
throw new ProgramError('You are not currently logged in');
Expand Down Expand Up @@ -3116,7 +3116,7 @@ export const handleProvisioningProfileRemove = async (command: ProgramCommand, p
}
};

const handleConfigCommand = (command: ProgramCommand) => {
export const handleConfigCommand = (command: ProgramCommand) => {
const action = command.name();
const key = command.args()[0] || '';

Expand Down Expand Up @@ -3147,7 +3147,7 @@ const handleConfigCommand = (command: ProgramCommand) => {
}
};

const handleOrganizationCommand = async (command: ProgramCommand, params: any) => {
export const handleOrganizationCommand = async (command: ProgramCommand, params: any) => {
// Organization validation and resolution
if (params.organization && (!params.organizationId || params.organizationId === 'all' || params.organizationId === 'current')) {
const organizations = await getOrganizations();
Expand Down Expand Up @@ -3959,7 +3959,7 @@ export const handlePublishView = async (command: ProgramCommand, params: any) =>
});
};

const handlePublishCommand = async (command: ProgramCommand, params: any) => {
export const handlePublishCommand = async (command: ProgramCommand, params: any) => {
// Parameter validations
validatePublishPlatform(params);
await validatePublishProfileParams(command, params);
Expand Down Expand Up @@ -4076,7 +4076,7 @@ const handlePublishCommand = async (command: ProgramCommand, params: any) => {
}
};

const handleBuildCommand = async (command: ProgramCommand, params:any) => {
export const handleBuildCommand = async (command: ProgramCommand, params:any) => {
// Build profile validation and resolution
if (params.profile && !params.profileId) {
const buildProfiles = await getBuildProfiles();
Expand Down Expand Up @@ -5537,7 +5537,7 @@ ${variableGroups.map((group: any) => ` - ${group.name}`).join('\n')}`);
}
}

const handleDistributionCommand = async (command: ProgramCommand, params: any) => {
export const handleDistributionCommand = async (command: ProgramCommand, params: any) => {
// Validate parameters for commands that need them
await validateDistributionProfileParams(command, params);
await validateTestingGroupParams(command, params);
Expand Down Expand Up @@ -5576,7 +5576,7 @@ const handleDistributionCommand = async (command: ProgramCommand, params: any) =
}


const handleSigningIdentityCommand = async (command: ProgramCommand, params: any) => {
export const handleSigningIdentityCommand = async (command: ProgramCommand, params: any) => {
// Validate parameters for commands that need them
await validateCertificateParams(command, params);
await validateKeystoreParams(command, params);
Expand Down Expand Up @@ -5620,7 +5620,7 @@ const handleSigningIdentityCommand = async (command: ProgramCommand, params: any
}
}

const handleEnterpriseAppStoreCommand = async (command: ProgramCommand, params: any) => {
export const handleEnterpriseAppStoreCommand = async (command: ProgramCommand, params: any) => {
// Validate enterprise profile and app version parameters
await validateEnterpriseProfileParams(command, params);
await validateEnterpriseAppVersionParams(command, params);
Expand Down Expand Up @@ -5656,7 +5656,7 @@ const handleEnterpriseAppStoreCommand = async (command: ProgramCommand, params:
}
}

async function downloadBuildLogs(taskIdOrParams: string | { commitId?: string; buildId?: string; branchId?: string; profileId?: string; profileName?: string; branchName?: string; path?: string; fileName?: string }, params?: any) {
export async function downloadBuildLogs(taskIdOrParams: string | { commitId?: string; buildId?: string; branchId?: string; profileId?: string; profileName?: string; branchName?: string; path?: string; fileName?: string }, params?: any) {
const progressSpinner = createOra('Preparing to download Build Logs...').start();

let effectiveTaskId: string | null = null;
Expand Down Expand Up @@ -5906,7 +5906,7 @@ async function downloadBuildLogs(taskIdOrParams: string | { commitId?: string; b
}
}

async function downloadPublishLogs(publishDetail: any, platform: string, publishProfileId: string, userProvidedPath?: string) {
export async function downloadPublishLogs(publishDetail: any, platform: string, publishProfileId: string, userProvidedPath?: string) {
if (!publishDetail || !publishDetail.id) {
return;
}
Expand Down Expand Up @@ -5999,7 +5999,7 @@ async function downloadPublishLogs(publishDetail: any, platform: string, publish
}
}

async function checkPublishStatusDirectly(platform: string, publishProfileId: string, appVersionId: string): Promise<{status: number, detail?: any}> {
export async function checkPublishStatusDirectly(platform: string, publishProfileId: string, appVersionId: string): Promise<{status: number, detail?: any}> {
try {
const url = `publish/v1/profiles/${platform}/${publishProfileId}/app-versions/${appVersionId}/publish`;

Expand All @@ -6023,7 +6023,7 @@ async function checkPublishStatusDirectly(platform: string, publishProfileId: st
}
}

async function monitorPublishProcess(params: any) {
export async function monitorPublishProcess(params: any) {
const { platform, publishProfileId, appVersionId, publishId } = params;

const progressSpinner = getConsoleOutputType() === 'json' ?
Expand Down Expand Up @@ -6412,7 +6412,7 @@ async function monitorPublishProcess(params: any) {
}
}

async function handleSuccessfulPublish(params: any, progressSpinner: any) {
export async function handleSuccessfulPublish(params: any, progressSpinner: any) {
try {
const publishDetail = await getPublisDetailById(params);

Expand Down Expand Up @@ -6452,7 +6452,7 @@ async function handleSuccessfulPublish(params: any, progressSpinner: any) {
}
}

async function handleFailedPublish(params: any, progressSpinner: any) {
export async function handleFailedPublish(params: any, progressSpinner: any) {
try {
const publishDetail = await getPublisDetailById(params);
console.log(chalk.red('\nPublish process did not complete successfully.'));
Expand Down Expand Up @@ -6493,7 +6493,7 @@ async function handleFailedPublish(params: any, progressSpinner: any) {
}
}

function findCommandByParts(parts: string[], commandList: CommandType[]): CommandType | undefined {
export function findCommandByParts(parts: string[], commandList: CommandType[]): CommandType | undefined {
if (!parts.length) return undefined;
const [head, ...tail] = parts;
const found = commandList.find(cmd => cmd.command === head);
Expand Down
14 changes: 7 additions & 7 deletions src/core/interactive-runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ import { AppcircleExitError } from './AppcircleExitError';
// Simple multiline input using readline for copy-paste support
import * as readline from 'readline';

const getSimpleMultilineInput = async (message: string): Promise<string> => {
export const getSimpleMultilineInput = async (message: string): Promise<string> => {
console.log(chalk.cyan('?'), message);

return new Promise((resolve) => {
Expand Down Expand Up @@ -151,7 +151,7 @@ export const processParameterValue = (paramName: string, value: any): any => {
return value;
};

const handleInteractiveParamsOrArguments = async (
export const handleInteractiveParamsOrArguments = async (
commandParams: CommandType['params'] | CommandType['arguments'] = []
): Promise<Record<string, any> | undefined> => {
let params: any = {};
Expand Down Expand Up @@ -680,7 +680,7 @@ export const buildActionCallbackInput = (
};

// Step 4: Refactored main function using the helpers
const handleCommandParamsAndArguments = async (selectedCommand: CommandType, parentCommand: any): Promise<ProgramCommand | undefined> => {
export const handleCommandParamsAndArguments = async (selectedCommand: CommandType, parentCommand: any): Promise<ProgramCommand | undefined> => {
// Get parameters interactively, return undefined if halt/error
const params = await getInteractiveValues(selectedCommand.params);
if (params === undefined) {
Expand Down Expand Up @@ -758,7 +758,7 @@ export const parseCommandIndex = (selectedActionName: string): number => {
};

// Step 8: Function to handle back navigation with DI for stack manipulation
const handleBackNavigation = async (
export const handleBackNavigation = async (
handleSelectedCommandFn: typeof handleSelectedCommand,
stackPop = () => navigationStack.pop(),
getStackLength = () => navigationStack.length,
Expand All @@ -774,7 +774,7 @@ const handleBackNavigation = async (
};

// Step 9: Function to handle forward navigation with DI for stack manipulation
const handleForwardNavigation = async (
export const handleForwardNavigation = async (
selectedCommand: CommandType,
preparedCommand: ProgramCommand | undefined,
handleSelectedCommandFn: typeof handleSelectedCommand,
Expand All @@ -785,7 +785,7 @@ const handleForwardNavigation = async (
};

// Step 10: Refactored main function using the helpers
const handleSelectedCommand = async (command: CommandType, __parentCommand?: any): Promise<ProgramCommand | undefined> => {
export const handleSelectedCommand = async (command: CommandType, __parentCommand?: any): Promise<ProgramCommand | undefined> => {
// Step 1: Prepare command parameters and arguments
const preparedCommand = await handleCommandParamsAndArguments(command, __parentCommand);

Expand Down Expand Up @@ -2096,7 +2096,7 @@ export const adjustCommandIndexForAuthGrouping = (selectedCommandIndex: number,
return adjustedIndex;
};

const runCommandsInteractivelyInner = async () => {
export const runCommandsInteractivelyInner = async () => {
let selectedCommand: (typeof Commands)[number];
let selectedCommandDescription = '';
let selectedCommandIndex = -1;
Expand Down
Loading