Set no_attribute_check on additional_collection with strong_parameters #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add gemfile for ruby 2.6.6 rails 5.2.6
# Conflicts: # .ruby-version # Appraisals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given a controller using strong parameters with filter_resource_access and additional_collection
A call to an action of the additional_collection should not try to instantiate an object from params[:id].
A bug in controller/rails.rb missed to add additional_collection actions to the no_attribute_check array.
Test only covered the case strong_attributes: false
I added tests and fixed the bug.