Add a textarea element #212
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new clear options to set a value for textareas. By default, in chrome selenium test, when `set` value of text-related node, it would only prepend the first line. As the capybara chrome node: it only send a space and a backspace to clear the text. https://bit.ly/3zpJZYJ However, this will **ONLY** clear the first line of the textarea. In this commit, we added a Textarea element to override the `set` method to clear all text in the textarea. This is following the set definition in the Capybara: it says we could use `[[:command, 'a'], :backspace]` to clear all text. Github capybara/selenium/node.rb#L55: https://bit.ly/3CtlTP3 It works both for firefox and chrome
limbov8
force-pushed
the
liboAddSupportForChromeWebdriver
branch
2 times, most recently
from
f5f3a0b to
b4190e0
Compare
added 2 commits
October 1, 2021 13:13
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new clear options to set a value for textareas. By default, in
the chrome selenium test, when
setvalue of text-related node, it wouldonly prepend the first line. As the capybara chrome node: it only sends
space and backspace to clear the text. https://bit.ly/3zpJZYJ
However, this will ONLY clear the first line of the text area.
In this commit, we added a Textarea element to override the
setmethodto clear all text in the text area.
This is following the set definition in the Capybara: it says we could
use
[[:command, 'a'], :backspace]to clear all text.Github capybara/selenium/node.rb#L55: https://bit.ly/3CtlTP3
It works both for firefox and chrome