SPICE-0021 Implement Pkl binary renderer and parser #1203
Conversation
HT154
force-pushed
the
binary-renderer
branch
4 times, most recently
from
b7285fb to
bee69cc
Compare
There was a problem hiding this comment.
This PR extracts String-specific functionality to a new AbstractStringRenderer subclass so that binary renderers can still benefit from the converter logic here in AbstractRenderer. This is a breaking change for any out-of-tree inheritors from AbstractRenderer but the fix is as simple as s/AbstractRenderer/AbstractStringRenderer/g.
| return new PklBinaryDecoder( | ||
| unpacker, new Importer(module.getVmClass().getPClassInfo().getModuleUri())) |
There was a problem hiding this comment.
This is the piece I'm least confident in. Currently, the parser API requires users to supply a module as context. This module value is used to determine the URI of the "importing" module passed to SecurityManager.checkImportModule. Ideally this would be derived automatically from the call stack, but I'm unsure how to do that. I also see some utility to allowing callers to set this explicitly, eg. in cases where the parse happens inside a module in some package (which would in turn need to accept the context parameter from its caller).
HT154
force-pushed
the
binary-renderer
branch
5 times, most recently
from
4b9a4a2 to
3a9b196
Compare
HT154
force-pushed
the
binary-renderer
branch
from
3a9b196 to
9b4415b
Compare
HT154
changed the title
This PR is composed of two commits: the first adds the new functionality, the second regenerates all changed snippet outputs. Please review just the first commit.
Implements SPICE-0021
Resolves #994