Fix problems preventing xcodebuild with BUILD_LIBRARY_FOR_DISTRIBUTIO…#90
Open
artem-shvetsov wants to merge 1 commit intoapple:mainfrom
Open
Fix problems preventing xcodebuild with BUILD_LIBRARY_FOR_DISTRIBUTIO…#90artem-shvetsov wants to merge 1 commit intoapple:mainfrom
artem-shvetsov wants to merge 1 commit intoapple:mainfrom
Conversation
…N=YES. Improved encapsulation
Author
|
Pls consider to accept this PR to make the library evolution tracking possible |
Lukasa
requested changes
Mar 2, 2025
Contributor
Lukasa
left a comment
Lukasa
left a comment
There was a problem hiding this comment.
Thanks for filing this. Unfortunately, we don’t supply a stable ABI for this library, and so we don’t support using BUILD_LIBRARY_FOR_DISTRIBUTION. The performance impact of removing these annotations is too high for us to work with, sadly.
Can you find a way to avoid setting that flag for this library? You shouldn’t actually need a stable ABI for most use-cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to generate .swiftinterface (with xcodebuild BUILD_LIBRARY_FOR_DISTRIBUTION=YES) for library evolution tracking, compile errors occur due to using a big number of @inlinable and @usabelFromInline declarations