build: Make swift-crypto build on Windows #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add the Windows Arm64 assembly files to the CMake build. * Add appropriate CMake options for swift-crypto to build on Windows. Fixes apple#369
Lukasa
reviewed
Jun 27, 2025
| gen/bcm/sha512-armv8-win.S | ||
| gen/bcm/vpaes-armv8-win.S | ||
| gen/crypto/chacha-armv8-win.S | ||
| gen/crypto/chacha20_poly1305_armv8-win.S) |
There was a problem hiding this comment.
These files are generated automatically by this script in swift-nio. I think this first needs a patch to swift-nio to ensure that this script can actually generate these two stanzas. Are you open to making that change?
There was a problem hiding this comment.
I edited the file here to be more friendly for the script. I opened apple/swift-nio#3275 but I could not figure out how to test it.
|
FYI I hit a compiler crash with this, see swiftlang/swift#82589 |
|
Very useful call-out, thankyou. |
Lukasa
approved these changes
Jul 21, 2025
|
I'm confused about why this is still failing. When I run it on my Linux box against this PR, it looks like it should pass: |
|
When I run it I get a very simple diff. I'll try applying it and see what happens. |
|
Yup, that was it. |
etcwilde
pushed a commit
to etcwilde/swift-crypto
that referenced
this pull request
Jul 22, 2025
Make swift-crypto build on Windows - [X] I've run tests to see all new and existing tests pass - [X] I've followed the code style of the rest of the project - [X] I've read the [Contribution Guidelines](CONTRIBUTING.md) - [X] I've updated the documentation if necessary - [N/A] I've run `.script/generate_boilerplate_files_with_gyb` and included updated generated files in a commit of this pull request Currently, swift-crypto on the main branch does not build on Windows. * Add the Windows Arm64 assembly files to the CMake build. * Add appropriate CMake options for swift-crypto to build on Windows. swift-crypto can be built on Windows from main Fixes apple#369 --------- Co-authored-by: Cory Benfield <[email protected]> (cherry picked from commit 9934678)
4 tasks
etcwilde
pushed a commit
to etcwilde/swift-crypto
that referenced
this pull request
Jul 22, 2025
Make swift-crypto build on Windows - [X] I've run tests to see all new and existing tests pass - [X] I've followed the code style of the rest of the project - [X] I've read the [Contribution Guidelines](CONTRIBUTING.md) - [X] I've updated the documentation if necessary - [N/A] I've run `.script/generate_boilerplate_files_with_gyb` and included updated generated files in a commit of this pull request Currently, swift-crypto on the main branch does not build on Windows. * Add the Windows Arm64 assembly files to the CMake build. * Add appropriate CMake options for swift-crypto to build on Windows. swift-crypto can be built on Windows from main Fixes apple#369 --------- Co-authored-by: Cory Benfield <[email protected]> (cherry picked from commit 9934678)
Lukasa
pushed a commit
that referenced
this pull request
Jul 22, 2025
Make swift-crypto build on Windows - [X] I've run tests to see all new and existing tests pass - [X] I've followed the code style of the rest of the project - [X] I've read the [Contribution Guidelines](CONTRIBUTING.md) - [X] I've updated the documentation if necessary - [N/A] I've run `.script/generate_boilerplate_files_with_gyb` and included updated generated files in a commit of this pull request Currently, swift-crypto on the main branch does not build on Windows. * Add the Windows Arm64 assembly files to the CMake build. * Add appropriate CMake options for swift-crypto to build on Windows. swift-crypto can be built on Windows from main Fixes #369 --------- Co-authored-by: Cory Benfield <[email protected]> (cherry picked from commit 9934678) (#370) Co-authored-by: Fabrice de Gans <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make swift-crypto build on Windows
Checklist
If you've made changes to
gybfiles.script/generate_boilerplate_files_with_gyband included updated generated files in a commit of this pull requestMotivation:
Currently, swift-crypto on the main branch does not build on Windows.
Modifications:
Result:
swift-crypto can be built on Windows from main
Fixes #369