-
Notifications
You must be signed in to change notification settings - Fork 187
Fix broken Windows tests (#350) #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test runners for Windows were failing to load the paths from disk for test vectors. This patch cleans up the loading logic. (cherry picked from commit 1f483f4)
etcwilde
approved these changes
Jul 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
fabianfett
approved these changes
Jul 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4 tasks
Steelskin
added a commit
to Steelskin/swift
that referenced
this pull request
Jul 23, 2025
Changelog: * apple/swift-cyrpto@d79c573 Make Build: Disable CMP0157 (apple/swift-crpto#387) * apple/swift-cyrpto@ebcbfc6 build: Make swift-crypto build on Windows (apple/swift-crypto#385) * apple/swift-crypto@785709b Fix broken Windows tests (apple/swift-crypto#350) (apple/swift-crypto#386)
Steelskin
added a commit
to Steelskin/swift
that referenced
this pull request
Jul 23, 2025
Changelog: * apple/swift-crypto@d79c573 Make Build: Disable CMP0157 (apple/swift-crpto#387) * apple/swift-crypto@ebcbfc6 build: Make swift-crypto build on Windows (apple/swift-crypto#385) * apple/swift-crypto@785709b Fix broken Windows tests (apple/swift-crypto#350) (apple/swift-crypto#386)
Steelskin
added a commit
to Steelskin/swift
that referenced
this pull request
Jul 23, 2025
Changelog: * apple/swift-crypto@d79c573 Make Build: Disable CMP0157 (apple/swift-crypto#387) * apple/swift-crypto@ebcbfc6 build: Make swift-crypto build on Windows (apple/swift-crypto#385) * apple/swift-crypto@785709b Fix broken Windows tests (apple/swift-crypto#350) (apple/swift-crypto#386)
Steelskin
added a commit
to Steelskin/swift
that referenced
this pull request
Jul 23, 2025
Changelog: * apple/swift-crypto@d79c573 Make Build: Disable CMP0157 (apple/swift-crypto#387) * apple/swift-crypto@ebcbfc6 build: Make swift-crypto build on Windows (apple/swift-crypto#385) * apple/swift-crypto@785709b Fix broken Windows tests (apple/swift-crypto#350) (apple/swift-crypto#386)
Steelskin
added a commit
to Steelskin/swift
that referenced
this pull request
Jul 23, 2025
Changelog: * apple/swift-crypto@d79c573 Make Build: Disable CMP0157 (apple/swift-crypto#387) * apple/swift-crypto@ebcbfc6 build: Make swift-crypto build on Windows (apple/swift-crypto#385) * apple/swift-crypto@785709b Fix broken Windows tests (apple/swift-crypto#350) (apple/swift-crypto#386)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test runners for Windows were failing to load the paths from disk for test vectors. This patch cleans up the loading logic.
(cherry picked from commit 1f483f4)