CMake Build: Disable CMP0157 #387
Merged
+0
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug in CMake CMP0157 where if library A depends on a non-Swift library B, which in turns depends on a Swift library C, library A will depend on a swiftmodule for B. B doesn't have a swiftmodule, so the build fails. Disable CMP0157 for now.
|
Non-owner LGTM. I just hit the same issue. This seemed to work with more recent CMake versions. |
Lukasa
approved these changes
Jul 23, 2025
Steelskin
added a commit
to Steelskin/swift
that referenced
this pull request
Jul 23, 2025
Changelog: * apple/swift-crypto@d79c573 Make Build: Disable CMP0157 (apple/swift-crypto#387) * apple/swift-crypto@ebcbfc6 build: Make swift-crypto build on Windows (apple/swift-crypto#385) * apple/swift-crypto@785709b Fix broken Windows tests (apple/swift-crypto#350) (apple/swift-crypto#386)
Steelskin
added a commit
to Steelskin/swift
that referenced
this pull request
Jul 23, 2025
Changelog: * apple/swift-crypto@d79c573 Make Build: Disable CMP0157 (apple/swift-crypto#387) * apple/swift-crypto@ebcbfc6 build: Make swift-crypto build on Windows (apple/swift-crypto#385) * apple/swift-crypto@785709b Fix broken Windows tests (apple/swift-crypto#350) (apple/swift-crypto#386)
Steelskin
added a commit
to Steelskin/swift
that referenced
this pull request
Jul 23, 2025
Changelog: * apple/swift-crypto@d79c573 Make Build: Disable CMP0157 (apple/swift-crypto#387) * apple/swift-crypto@ebcbfc6 build: Make swift-crypto build on Windows (apple/swift-crypto#385) * apple/swift-crypto@785709b Fix broken Windows tests (apple/swift-crypto#350) (apple/swift-crypto#386)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in CMake CMP0157 where if library A depends on a non-Swift library B, which in turns depends on a Swift library C, library A will depend on a swiftmodule for B. B doesn't have a swiftmodule, so the build fails.
Currently hitting the following error on Windows CI:
ninja: error: 'swift/CCryptoBoringSSL.swiftmodule', needed by 'lib/libCCryptoBoringSSLShims.lib', missing and no known rule to make itDisabling CMP0157 for now.