Add Wasm build to pull_request.yml
#405
Open
+11
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that Wasm builds are tested on CI.
Checklist
If you've made changes to
gyb
files.script/generate_boilerplate_files_with_gyb
and included updated generated files in a commit of this pull requestMotivation:
The library currently doesn't build for Wasm on CI.
Modifications:
pull_request.yml
.static-sdk
/"Static SDK` job, which is incorrectly named named with vague wording: Musl Swift SDK is not the only one supporting static linking, Wasm is also statically linked by default.Result:
Build regressions on Wasm are prevented, jobs are named in a non-ambiguous way.