Conversation
|
@ktoso we can focus on your PR though, can close this one. It's just easier for me to finish it here. |
|
Happy for you to take it over. Fixed up CI so we now just do 5.10+ jobs. |
# Conflicts: # Sources/MultiNodeTestKitRunner/boot+MultiNodeTestKitRunner+Exec.swift
| case `static`(endpoints: Set<Cluster.Endpoint>, subscribe: (@escaping (Result<[Cluster.Endpoint], Error>) -> Void, @escaping (CompletionReason) -> Void) -> CancellationToken?) | ||
| case dynamic(serviceDiscovery: AnyServiceDiscovery, subscribe: (@escaping (Result<[Cluster.Endpoint], Error>) -> Void, @escaping (CompletionReason) -> Void) -> CancellationToken?) | ||
| case clusterDaemon(endpoint: Cluster.Endpoint, initialize: (ClusterSystem) -> Void) |
There was a problem hiding this comment.
Decided to put subscribe and initialize closures here, as otherwise it's quite confusing to have optional values in settings itself.
|
@ktoso I've went through code, cleaned up some stuff, executable is now called |
|
Hey guys is there any movement on this? |
|
@zastrozzi Hi! 👋 There are currently some really weird issues with tests that need to be tackled before we can merge everything. |
|
Hey no worries! If I have some time I'll see if I can help too. Are the testing problems cited elsewhere in an issue/PR? |
There is this issue, but it's really strange one, will try to ping and check once more. |
# Conflicts: # Sources/DistributedCluster/Cluster/DiscoveryShell.swift # Sources/MultiNodeTestKitRunner/boot+MultiNodeTestKitRunner+Exec.swift
|
we don't do API breakage, we could remove that, we're pre-1.0 |
Hm, can you elaborate a bit more? It's not really breaking anything, but you mean you don't wanna add something new to pre-1.0 and 1.0? |
|
The Pr validation triggered api compatibility checking, so I was saying we can disable that basically :) |
ah, ok, was confused a bit. 🙂 |
3 participants
Quite often people ask "How actors find each other" and clusterd could be a good example to show discoverability.
Again just stealing your code here @ktoso 🙂 Will just try to finish and prettify.