[SMT-0001]: task-local metrics factory proposal implementation draft#196
Draft
kukushechkin wants to merge 32 commits intoapple:mainfrom
Draft
[SMT-0001]: task-local metrics factory proposal implementation draft#196kukushechkin wants to merge 32 commits intoapple:mainfrom
kukushechkin wants to merge 32 commits intoapple:mainfrom
Conversation
55449c1 to
47c668f
Compare
30822ea to
50f83f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add task-local factory override for metrics to enable testing code that creates and emits metrics without global state
pollution. The factory is captured at metric creation time and used for the metric's entire lifetime.
Motivation:
Testing code that creates and emits metrics currently requires either:
Modifications:
Add
MetricsSystem.with(factory:)method that binds a factory to task-local context. Metrics created within thiscontext use the task-local factory instead of the global factory.
Result:
Metrics can be used and tests without global metrics factory bootstrapping and explicit factory propagation though dependency injection.