Add documentation of how trust roots settings affect validators#548
Merged
glbrntt merged 1 commit intoapple:mainfrom Jul 9, 2025
Merged
Conversation
Motivation: The trust roots settings have sometimes got non-obvious impacts on which validator is used. These are a legacy behaviour and so changing them is likely to cause services to encounter challenging bugs, so it's probably not worth fixing this behaviour without doing a deprecate-and-replace cycle. A deprecate-and-replace of TLSConfiguration is going to be necessary in the near-term because it is a suboptimal structure that is carrying a lot of load. For now, however, let's just make it possible for users to diagnose what is going on. Modifications: - Document the existing behaviour Result: Users have a chance of figuring out what is going on.
glbrntt
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The trust roots settings have sometimes got non-obvious impacts on which validator is used. These are a legacy behaviour and so changing them is likely to cause services to encounter challenging bugs, so it's probably not worth fixing this behaviour without doing a deprecate-and-replace cycle.
A deprecate-and-replace of TLSConfiguration is going to be necessary in the near-term because it is a suboptimal structure that is carrying a lot of load. For now, however, let's just make it possible for users to diagnose what is going on.
Modifications:
Result:
Users have a chance of figuring out what is going on.